Skip to content

Render custom map_index_template on task completion #49809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uranusjr merged 5 commits into from
May 5, 2025
Merged

Render custom map_index_template on task completion #49809

uranusjr merged 5 commits into from
May 5, 2025

Conversation

@purnachandergit
Copy link
Contributor

@purnachandergit purnachandergit commented Apr 26, 2025 •
edited
Loading

Fixes #49224

Implemented rendering of the map index template for both task success and failure cases following task execution.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:task-sdk labels Apr 26, 2025
@purnachandergit purnachandergit force-pushed the 49224 branch 2 times, most recently from 3650f91 to 9450ff9 Compare April 26, 2025 09:52
ashb
ashb reviewed Apr 26, 2025
View reviewed changes
Copy link
Member

@ashb ashb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up.

In addition to the changes I've requested this needs to be done as a Cadwyn API migration please. I haven't yet gotten sons to writing up the contribution docs for this, so is a bit of an exercise to the reader. Docs for it are at https://docs.cadwyn.dev/

tirkarthi
tirkarthi reviewed Apr 27, 2025
View reviewed changes
@purnachandergit purnachandergit force-pushed the 49224 branch 3 times, most recently from a10af55 to ea85197 Compare April 29, 2025 06:23
@phanikumv phanikumv requested a review from uranusjr April 29, 2025 06:36
@kaxil kaxil added this to the Airflow 3.0.1 milestone Apr 29, 2025
uranusjr
uranusjr reviewed Apr 29, 2025
View reviewed changes
kaxil
kaxil reviewed Apr 29, 2025
View reviewed changes
kaxil
kaxil reviewed Apr 29, 2025
View reviewed changes
@kaxil kaxil changed the title map index rendered on task completion #49224 Render custom map_index_template on task completion Apr 29, 2025
@kaxil
Copy link
Member

kaxil commented Apr 30, 2025

how are you getting along @purnachandergit ? Would like to get this merged soon, since I am planning to cur rc1 in next few days

@purnachandergit
Copy link
Contributor Author

purnachandergit commented Apr 30, 2025 •
edited
Loading

@kaxil , Got stuck with some other work

Working on test cases, will update the pr in 2 days

@purnachandergit purnachandergit requested a review from ashb May 2, 2025 09:20
kaxil
kaxil approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@kaxil kaxil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one unresolved comment from TP that you should reply to -- looks good to me otherwise

@kaxil kaxil added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label May 2, 2025
@purnachandergit purnachandergit requested a review from uranusjr May 4, 2025 16:50
@uranusjr uranusjr merged commit d3dc592 into apache:main May 5, 2025
97 checks passed
github-actions bot pushed a commit that referenced this pull request May 5, 2025
@purnachandergit
[v3-0-test] Render custom map_index_template on task completion (#4…
c37b41b 
…9809)

(cherry picked from commit d3dc592)

Co-authored-by: Purna Chander Dharam <53432718+purnachandergit@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented May 5, 2025

Backport successfully created: v3-0-test

Status Branch Result
✅ v3-0-test PR Link

@raphaelauv
Copy link
Contributor

raphaelauv commented May 5, 2025

@purnachandergit does it also fix this issue #39092 ? thaks

@uranusjr
Copy link
Member

uranusjr commented May 5, 2025

I don’t think this (alone) fixes the issue. The value needs to be calculated in the task worker, and then passed to the server via the execution API. This PR adds the field (and passes the value when the worker calculates it), but when you set the task state manually, there’s no worker involved and thus no value calculated.

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 5, 2025
@purnachandergit
[v3-0-test] Render custom map_index_template on task completion (ap…
f48bc2d 
…ache#49809)

(cherry picked from commit d3dc592)

Co-authored-by: Purna Chander Dharam <53432718+purnachandergit@users.noreply.github.com>
mvfc pushed a commit to mvfc/airflow that referenced this pull request May 6, 2025
@purnachandergit @mvfc
Render custom map_index_template on task completion (apache#49809)
044e071
kaxil pushed a commit that referenced this pull request May 6, 2025
@github-actions @purnachandergit
[v3-0-test] Render custom map_index_template on task completion (#4…
f558ead 
…9809) (#50194)

(cherry picked from commit d3dc592)

Co-authored-by: Purna Chander Dharam <53432718+purnachandergit@users.noreply.github.com>
@kaxil kaxil mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@kaxil kaxil kaxil approved these changes

@phanikumv phanikumv phanikumv approved these changes

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@uranusjr uranusjr Awaiting requested review from uranusjr

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API area:task-sdk backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

Airflow 3.0.1

Development

Successfully merging this pull request may close these issues.

map_index_template does not change the map index displayed in the UI

7 participants

@purnachandergit @kaxil @raphaelauv @uranusjr @ashb @tirkarthi @phanikumv